Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wgpu-core/-hal] move raytracing alignments into hal #6563

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

Vecvec
Copy link
Contributor

@Vecvec Vecvec commented Nov 17, 2024

Connections
follows #6291

Description
There were a few places that had todos to move into hal, which this does.

Testing
All previously added tests still succeed.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • N/A --target wasm32-unknown-unknown
    • N/A --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@Vecvec Vecvec requested a review from a team as a code owner November 17, 2024 02:31
Copy link
Contributor

@nical nical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on the fence about whether to default to zero alignment vs using a conservative default alignement constant of 256 in hal, but we can change that later if we feel strongly enough. This patch is an improvement.

Thanks!

@nical nical merged commit 6f5014f into gfx-rs:trunk Nov 19, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants